search: Exclude hidden results from keynav

Since commit 3fb02843, we no longer skip allocation for
results that don't fit the width, and give them a 0x0
allocation instead.

That has the unintended side effect of those children now
being available to keynav. There are cases where we want
0-sized actors to be part of the focus chain (e.g. FocusTrap),
but this isn't one of them, so explicitly exclude 0-sized
children from keynav.

https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4470

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1916>

diff --git a/js/ui/search.js b/js/ui/search.js
index de13d6e0141731eee352c78f4edbc83fda366ca6..7300b053e37b5f54ad86ccbc3b2fdac2c0af3d52 100644 (file)
--- a/js/ui/search.js
+++ b/js/ui/search.js
@@ -429,6 +429,7 @@ var GridSearchResultsLayout = GObject.registerClass({
                 childBox.set_size(0, 0);
 
             child.allocate(childBox);
+            child.can_focus = childBox.get_area() > 0;
 
             childBox.x1 += childWidth;
         }